Skip to content

[5.x] Ensure null values are filtered out in dictionary field config #11773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

[5.x] Ensure null values are filtered out in dictionary field config #11773

merged 1 commit into from
May 8, 2025

Conversation

duncanmcclean
Copy link
Member

This pull request fixes an issue I spotted where null values weren't being filtered out when saving a dictionary field's config options.

-
  handle: dictionary_field
  field:
    dictionary:
      type: countries
      region: null
      emojis: true
    type: dictionary
    display: 'Dictionary Field'

^ In this example, the region key shouldn't be persisted when its null.

@duncanmcclean duncanmcclean changed the title [5.x] Ensure null values are filtered out when saving dictionary field config [5.x] Ensure null values are filtered out in dictionary field config May 8, 2025
@jasonvarga jasonvarga merged commit d3f4f70 into 5.x May 8, 2025
27 checks passed
@duncanmcclean duncanmcclean deleted the filter-null-values-dictionary-fields branch May 8, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duncanmcclean @jasonvarga